[LinuxPPS] ntpd

[Rodolfo Giometti]

On Thu, Aug 03, 2006 at 08:16:42PM +0200, Folkert van Heusden wrote:
> 
> Nope:
> 
> [42950148.900000] Serial: 8250/16550 driver $Revision: 1.90 $ 4 ports, IRQ sharing enabled
> [42950148.930000] PPS-TEST port line 0
> [42950148.930000] PPS-TEST2 port line 0
> [42950148.930000] drivers/serial/8250.c: registered 8250 source 0 at line 0
> [42950148.930000] PPS-TEST port line 1
> [42950148.930000] PPS-TEST2 port line 1
> [42950148.960000] drivers/serial/8250.c: registered 8250 source 1 at line 1
> [42950148.960000] PPS-TEST port line 2
> [42950148.960000] PPS-TEST2 port line 2
> [42950148.980000] drivers/serial/8250.c: registered 8250 source 2 at line 2
> [42950148.980000] PPS-TEST port line 3
> [42950148.980000] PPS-TEST2 port line 3
> [42950149.040000] drivers/serial/8250.c: registered 8250 source 3 at line 3

No problem, it's ok since now I know that what is fail on the first
four ports is this test:

        if (port->line >= drv->nr)
                return -EINVAL;

in uart_add_one_port() function. Just to be sure modify the code as
follow:

   int uart_add_one_port(struct uart_driver *drv, struct uart_port *port)
   {
           struct uart_state *state;
           int ret = 0;

           BUG_ON(in_interrupt());

   printk("PPS-TEST0 port line %d\n", port->line);
           if (port->line >= drv->nr)
                   return -EINVAL;

           state = drv->state + port->line;

           mutex_lock(&port_mutex);
           mutex_lock(&state->mutex);
           if (state->port) {
                   ret = -EINVAL;
                   goto out;
           }
   printk("PPS-TEST port line %d\n", port->line);

           state->port = port;

           port->cons = drv->cons;
           port->info = state->info;

If this works I'll produce a new patch ASAP!

Thanks a lot,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://ml.enneenne.com/pipermail/linuxpps/attachments/20060803/c36efe01/attachment.pgp