[LinuxPPS] http://ftp.enneenne.com/pub/misc/linuxpps/patches/ntp-pps-2.6.19.diff

Rodolfo Giometti giometti at enneenne.com
Tue Feb 6 22:14:39 CET 2007


On Mon, Feb 05, 2007 at 03:25:28PM +0100, Udo van den Heuvel wrote:
> [snip]
>   CC      drivers/pci/setup-bus.o
>   CC      drivers/pci/pci-acpi.o
>   LD      drivers/pci/built-in.o
>   CC      drivers/pps/pps.o
> drivers/pps/pps.c: In function
> ânuxpps_nl_data_readyâdrivers/pps/pps.c:316: error: âruct
> netlink_skb_parmsâas no member named ât_pidâake[2]: ***
> [drivers/pps/pps.o] Error 1
> make[1]: *** [drivers/pps] Error 2
> make: *** [drivers] Error 2
> [root at epia linux]#
> 
> Any ideas?

Looking at kernel changelog I see:

   $  git-show 4e9b82693542003b028c8494e9e3c49615b91ce7 | head
   commit 4e9b82693542003b028c8494e9e3c49615b91ce7
   Author: Thomas Graf <tgraf at suug.ch>
   Date:   Mon Nov 27 09:25:58 2006 -0800

       [NETLINK]: Remove unused dst_pid field in netlink_skb_parms
       
       The destination PID is passed directly to netlink_unicast()
       respectively netlink_multicast().
       
       Signed-off-by: Thomas Graf <tgraf at suug.ch>

And continuing to read it seems enought this patch:

   diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c
   index a084eb2..ea28e71 100644
   --- a/drivers/pps/pps.c
   +++ b/drivers/pps/pps.c
   @@ -313,7 +313,6 @@ static void linuxpps_nl_data_ready(struct sock *sk, int len)
                   NETLINK_CB(skb).groups = 0;     /* not in mcast groups */
    #endif
                   NETLINK_CB(skb).pid = 0;        /* from the kernel */
   -               NETLINK_CB(skb).dst_pid = nlh->nlmsg_pid;
    #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,15)
                   NETLINK_CB(skb).dst_groups = 0; /* not in mcast groups */
    #else

Please, test the code and report possible bugs! Expecially should be
tested systems with multiple GPS antennas.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127



More information about the LinuxPPS mailing list