[LinuxPPS] compile fail with latest git pull

Rodolfo Giometti giometti at enneenne.com
Tue Feb 20 09:38:04 CET 2007


On Tue, Feb 20, 2007 at 09:28:36AM +0100, Rodolfo Giometti wrote:

> The function uart_handle_dcd_change is called as:
> 
>    uart_handle_dcd_change(&up->port, status & UART_MSR_DCD);
> 
> so checking again the UART_MSR_DCD flag is unneeded.

That's why I think we need also the following patch:

diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index ea987af..d89a0f7 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -472,7 +472,7 @@ uart_handle_dcd_change(struct uart_port *port, unsigned int         struct uart_info *info = port->info;
 
 #ifdef CONFIG_PPS
-       if ((port->flags & UPF_HARDPPS_CD) && status) {
+       if ((port->flags & UPF_HARDPPS_CD)) {
                if (status) {
                        pps_event(up->port.pps_source, PPS_CAPTUREASSERT, port);
                        dbg("serial8250: PPS assert event at %lu on source #%d",

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127



More information about the LinuxPPS mailing list