[LinuxPPS] 18 Aug 06:50 - x86: fix i486 suspend to disk CR4 oops

linuxpps: David Fries <> webmaster at enneenne.com
Wed Aug 20 00:00:06 CEST 2008


x86: fix i486 suspend to disk CR4 oops  
  
arch/x86/power/cpu_32.c __save_processor_state calls read_cr4()  
only a i486 CPU doesn't have the CR4 register. Trying to read it  
produces an invalid opcode oops during suspend to disk.  
  
Use the safe rc4 reading op instead. If the value to be written is  
zero the write is skipped.  
  
arch/x86/power/hibernate_asm_32.S  
done: swapped the use of %eax and %ecx to use jecxz for  
the zero test and jump over store to %cr4.  
restore_image: s/%ecx/%eax/ to be consistent with done:  
  
In addition to __save_processor_state, acpi_save_state_mem,  
efi_call_phys_prelog, and efi_call_phys_epilog had checks added  
(acpi restore was in assembly and already had a check for  
non-zero). There were other reads and writes of CR4, but MCE and  
virtualization shouldn't be executed on a i486 anyway.  
  
Signed-off-by: David Fries   
Acked-by: H. Peter Anvin   
Signed-off-by: Ingo Molnar   
  
arch/x86/kernel/acpi/sleep.c  
arch/x86/kernel/efi_32.c  
arch/x86/power/cpu_32.c  
arch/x86/power/hibernate_asm_32.S

URL: http://gitweb.enneenne.com/?p=linuxpps;a=commit;h=e532c06f2a835b5cc4f4166f467437d9b09c1d0e



More information about the LinuxPPS mailing list