[LinuxPPS] 24 Jan 22:06 - spi: omap2_mcspi PIO RX fix

linuxpps: Kalle Valo <> webmaster at enneenne.com
Sun Jan 27 18:30:10 CET 2008


spi: omap2_mcspi PIO RX fix  
  
Before transmission of the last word in PIO RX_ONLY mode rx+tx mode  
is enabled:  
  
/* prevent last RX_ONLY read from triggering  
* more word i/o: switch to rx+tx  
*/  
if (c == 0 && tx == NULL)  
mcspi_write_cs_reg(spi,  
OMAP2_MCSPI_CHCONF0, l);  
  
But because c is decremented after the test, c will never be zero and  
rx+tx will not be enabled. This breaks RX_ONLY mode PIO transfers.  
  
Fix it by decrementing c in the beginning of the various I/O loops.  
  
Signed-off-by: Kalle Valo   
Signed-off-by: David Brownell   
Signed-off-by: Andrew Morton   
Signed-off-by: Linus Torvalds   
  
drivers/spi/omap2_mcspi.c

URL: http://gitweb.enneenne.com/?p=linuxpps;a=commit;h=feed9bab7b14b77be8d796bcee95e2343fb82955



More information about the LinuxPPS mailing list