[LinuxPPS] [PATCH] LinuxPPS module locking is currently broken

George Spelvin linux at horizon.com
Tue Nov 11 16:55:52 CET 2008


It lets you unload the pps_tty ldisc while it's in use, leading to kaboom.
Fortunately, the fix is a one-liner.

(I'm working on a larger patch series, but this stands on its own.)

commit d23dfa4c0bfc1b10a1c70e1ee22223a1f99c4970
Author: George Spelvin <linux at horizon.com>
Date:   Tue Nov 11 10:50:27 2008 -0500

    pps-ldisc: Get module locking working.

diff --git a/drivers/pps/clients/pps-ldisc.c b/drivers/pps/clients/pps-ldisc.c
index 8b39ab3..ddea552 100644
--- a/drivers/pps/clients/pps-ldisc.c
+++ b/drivers/pps/clients/pps-ldisc.c
@@ -93,6 +93,7 @@ static void pps_tty_close(struct tty_struct *tty)
 }
 
 struct tty_ldisc_ops pps_ldisc_ops = {
+	.owner		= THIS_MODULE,
 	.magic		= PPS_TTY_MAGIC,
 	.name		= "pps_tty",
 	.dcd_change	= pps_tty_dcd_change,



More information about the LinuxPPS mailing list