[LinuxPPS] [PATCH 11/11] PPS: Make permission checking more sensible.

[Rodolfo Giometti]

On Fri, Feb 06, 2009 at 03:08:32PM +0100, Udo van den Heuvel wrote:
> George Spelvin wrote:
>> Rather that play with CAP_SYS_TIME and all that, just require the file be
>> opened with read access (which requires read permission on the device) to
>> get timestamps, and write permission to alter the global parameters.
>
> (and also other patches)
>
> Thanks!

I agree with Udo! Thanks for your job. :)

> I hope some people can look over them and that we can all test them.

Yes, these patches should be tested by others people since the
LinuxPPS core is heavily modified.

> Did you run with ntpd on a kernel with these changes?

If so, please reports your tests.

> Do these patches eliminate eny of the issues remaining for kernel  
> inclusion? (lost track a bit)

I think these are going to stop kernel inclusion! :'(

Let me explain a bit. Currently I submit only LinuxPPS core for
inclusion in order to have a stable base code to work on. However
these patches modifies that base in several points, so what I sent
should be revisited.

Now we should deciced what to do:

a) stop kernel inclusion, then test these patches and after all
resubmitting the code, or

b) don't stop kernel inclusion and then repropose these patches
against linux vanilla.

I vote for b). :)

> Rodolfo, can you agree with these patches and adapt them to or  
> incorporate them into the LinuxPPS kernel patch?

I still have to read them carefully but I'm willing to accept them
after some positive feedbacks.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti