[LinuxPPS] Rodolfo's and Alexander's patches together.

clemens at dwf.com clemens at dwf.com
Sun Feb 28 05:42:30 CET 2010


This weekend I spent some time and merged Rodolfo's patch of 14Feb with
Alexander Gordeev's patch of 24Feb.

Either patch applied cleanly alone, but when you applied Rodolfo's patch
first, and then Alexander's on top of it there were some minor things that
needed to be fixed in Makefiles and Kconfig files.

The two merged patches could use a bit of editorial work to 'pretty things up'
Alexander has a 'generators' subdirectory that Rodolfo's ktimer should be
moved down into, and the order of things that you see when doing 'make xconfig'
from the pps directory should be changed (and perhaps some of the descriptions
need to be changed) now that there are both serial and parallel drivers.

There are no configuration options for Gordeev's changes, I don't know if that 
will remain the case.

The compile of the kernel went cleanly, but ntp reported an error with kcbind.
This took me a LONG time to run down, and in the end I was surprised to find
the problem in timepps.h .  Rodolfo had just said 'it doesn't exist'  for 
kcbind
there rather than having a call to the kernel, and then code in the kernel that
reported the same thing.  Also he did not have the necessary #define nor the
necessary structure for kc_bind in the include files.  Mumph.

So I fixed the Makefile/Kconfig overlaps, added the #define and struct from the
(Gordeev patch back into the user includes, and fixed up timepps.h to actually
call the kernel.

With this everything works.

However there is one strange result.
The time offset as seen with ntpdc/dmpeers converges to about a 43us offset, 
and then never seems to get closer.  With the Rodolfo patch alone this error
goes to zero.

So, there is still work to be done to understand this merging of these patches.

It is great tho, that the Gordeev patch merges nicely with Rodolfo's code, and
wasn't a totally separate venture. I was able to use my serial PPS source, tho
it seems that Gordeev has only used his (I believe more accurate) parallel port
devices.

Its been an interesting weekend.

-- 
                                        Reg.Clemens
                                        reg at dwf.com





More information about the LinuxPPS mailing list