[LinuxPPS] 12 Jul 21:33 - ov7670: clean up ov7670_read semantics

[linuxpps: Andres Salomon <>]

ov7670: clean up ov7670_read semantics  
  
Cortland Setlow pointed out a bug in ov7670.c where the result from  
ov7670_read() was just being checked for !0, rather than <0. This made me  
realize that ov7670_read's semantics were rather confusing; it both fills  
in 'value' with the result, and returns it. This is goes against general  
kernel convention; so rather than fixing callers, let's fix the function.  
  
This makes ov7670_read return <0 in the case of an error, and 0 upon  
success. Thus, code like:  
  
res = ov7670_read(...);  
if (!res)  
goto error;  
  
..will work properly.  
  
Signed-off-by: Cortland Setlow   
Signed-off-by: Andres Salomon   
Acked-by: Jonathan Corbet   
Cc:   
Signed-off-by: Andrew Morton   
Signed-off-by: Linus Torvalds   
  
drivers/media/video/ov7670.c

URL: http://gitweb.enneenne.com/?p=linuxpps;a=commit;h=bca5c2c550f16d2dc2d21ffb7b4712bd0a7d32a9