[LinuxPPS] [PATCH v2 2/2] pps: pps-gpio pps-echo implementation

Juan Solano jsm at jsolano.com
Wed Sep 26 21:38:23 CEST 2018


Hi Tom,
 
just some comments after a quick look at your patch:

* pps-gpio.txt
I would recommend adding the new options to the example.

* pps-gpio.c
Isn't the integer-based GPIO interface now deprecated?
https://www.kernel.org/doc/Documentation/gpio/consumer.txt
 
Should we use high resolution timers?
 
I have a working pps gpio output driver, working on a Beaglebone Black, which uses the new descriptor-based interface. Here it is in case it helps:
https://github.com/jsln/pps-gen-gpio/

Regards,
Juan Solano
--
Skype: jsolmen
jsolano.com



More information about the discussions mailing list